[Tests] Make test_full_upgrade less flaky - #4363
Merged
Merged
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Contributor
vicsn
force-pushed
the
tests/flaky_test_full_upgrade
branch
from
July 31, 2026 12:35
09541f4 to
cef20ce
Compare
Collaborator
Author
|
Rather than bumping the limits, I'd recommend retrying once ProvableHQ/snarkVM#3349 is merged (and used by snarkOS), at which point a lot fewer logs should be generated. |
Collaborator
Author
|
Confirmed locally that this test passes with current snarkVM. |
vicsn
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that the height check polled the node being restarted. Now the script waits until the node is able to serve its REST API before making judgements about its stability.
In addition, the consensus version was never checked, and the max number of warnings was too low - it was now raised to the value used in another script, though the question of whether
Received signature for an older batchis worthy of aWARNremains.Fixes #4356.